gl: Install the debug message callback for gl-debug
authorMatthias Clasen <mclasen@redhat.com>
Mon, 5 Oct 2020 18:08:55 +0000 (14:08 -0400)
committerMatthias Clasen <mclasen@redhat.com>
Mon, 5 Oct 2020 18:43:31 +0000 (14:43 -0400)
Always install the debug message callback when we can
and GDK_DEBUG=gl-debug is specified. Previously, we
were only installing the callback when the build was
a non-optimized debug build.

gdk/gdkglcontext.c

index 71a854816bd8115ff5abf68ce7d7204475a7d581..01c67688f2d1a521cbcbe923ea669dbc8ba75fc8 100644 (file)
@@ -864,7 +864,7 @@ gdk_gl_context_get_use_es (GdkGLContext *context)
   return priv->use_es > 0;
 }
 
-#ifdef G_ENABLE_CONSISTENCY_CHECKS
+#ifdef G_ENABLE_DEBUG
 static void
 gl_debug_message_callback (GLenum        source,
                            GLenum        type,
@@ -1008,8 +1008,11 @@ gdk_gl_context_check_extensions (GdkGLContext *context)
   priv->has_debug_output = epoxy_has_gl_extension ("GL_ARB_debug_output") ||
                            epoxy_has_gl_extension ("GL_KHR_debug");
 
-#ifdef G_ENABLE_CONSISTENCY_CHECKS
-  if (priv->has_debug_output)
+#ifdef G_ENABLE_DEBUG
+  display = gdk_draw_context_get_display (GDK_DRAW_CONTEXT (context));
+  gl_debug = GDK_DISPLAY_DEBUG_CHECK (display, GL_DEBUG);
+
+  if (priv->has_debug_output && gl_debug)
     {
       gdk_gl_context_make_current (context);
       glEnable (GL_DEBUG_OUTPUT);
@@ -1039,11 +1042,6 @@ gdk_gl_context_check_extensions (GdkGLContext *context)
         priv->is_legacy = TRUE;
     }
 
-#ifdef G_ENABLE_DEBUG
-  display = gdk_draw_context_get_display (GDK_DRAW_CONTEXT (context));
-  gl_debug = GDK_DISPLAY_DEBUG_CHECK (display, GL_DEBUG);
-#endif
-
   if (priv->has_khr_debug && gl_debug)
     {
       priv->use_khr_debug = TRUE;